Discussion:
D16499: Bump min ECM/KF5 dep version to 5.18
Friedrich W. H. Kossebau
2018-10-28 21:42:39 UTC
Permalink
kossebau created this revision.
kossebau added a reviewer: KDevelop.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
kossebau requested review of this revision.

REVISION SUMMARY
CI only tests with 5.18, so unknown if it even still builds with 5.14

REPOSITORY
R32 KDevelop

BRANCH
bumpminkftotested

REVISION DETAIL
https://phabricator.kde.org/D16499

AFFECTED FILES
CMakeLists.txt

To: kossebau, #kdevelop
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Friedrich W. H. Kossebau
2018-10-28 21:43:42 UTC
Permalink
kossebau added a comment.


This is for 5.3 branch.

REPOSITORY
R32 KDevelop

REVISION DETAIL
https://phabricator.kde.org/D16499

To: kossebau, #kdevelop
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Francis Herne
2018-10-28 21:53:31 UTC
Permalink
flherne accepted this revision as: flherne.
flherne added a comment.
This revision is now accepted and ready to land.


+1, as on IRC.

5.18 is found in Ubuntu 16.04 (Xenial); there's a CI build/test for that version and at least one real user (who complained when a commit broke the 5.18 build while the CI was down).

No still-relevant platform has KF5.15-17.

REPOSITORY
R32 KDevelop

BRANCH
bumpminkftotested

REVISION DETAIL
https://phabricator.kde.org/D16499

To: kossebau, #kdevelop, flherne
Cc: flherne, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Kevin Funk
2018-11-16 14:18:16 UTC
Permalink
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.


As said on IRC:
<kfunk> frinring: wouldn't change that in the stable branch
<kfunk> too late now, with 5.3.0 being released.
<kfunk> deps should stay at their resp. versions

Would abandon this.

REPOSITORY
R32 KDevelop

REVISION DETAIL
https://phabricator.kde.org/D16499

To: kossebau, #kdevelop, flherne, kfunk
Cc: kfunk, flherne, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Friedrich W. H. Kossebau
2018-11-16 16:17:56 UTC
Permalink
kossebau abandoned this revision.

REPOSITORY
R32 KDevelop

REVISION DETAIL
https://phabricator.kde.org/D16499

To: kossebau, #kdevelop, flherne, kfunk
Cc: kfunk, flherne, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Loading...