Discussion:
D17098: Make the filteringstrategy test work on Windows as well.
Morten Volden
2018-11-22 11:58:19 UTC
Permalink
volden created this revision.
volden added a reviewer: KDevelop.
Herald added a project: KDevelop.
volden requested review of this revision.

REVISION SUMMARY
This requires some changes to some of the regexes used in CompilerFilterStrategy to get to work. Also the test itself is now somewhat more specific about what path type to test on which platform.

TEST PLAN
Compile the changes on Windows and verify that the test now passes (In Debug mode). Compile the changes on Linux and verify that all tests pass (as before). Verify that the bench number still look reasonable

REPOSITORY
R32 KDevelop

BRANCH
fixFilteringStrategyOnWin (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17098

AFFECTED FILES
kdevplatform/outputview/outputfilteringstrategies.cpp
kdevplatform/outputview/tests/test_filteringstrategy.cpp
kdevplatform/outputview/tests/testlinebuilderfunctions.h

To: volden, #kdevelop
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Kevin Funk
2018-11-22 12:21:17 UTC
Permalink
kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R32 KDevelop

BRANCH
fixFilteringStrategyOnWin (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17098

To: volden, #kdevelop, kfunk
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Morten Volden
2018-11-22 13:34:29 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R32:35026c0881b5: Make the filteringstrategy test work on Windows as well. (authored by volden).

REPOSITORY
R32 KDevelop

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17098?vs=46002&id=46006

REVISION DETAIL
https://phabricator.kde.org/D17098

AFFECTED FILES
kdevplatform/outputview/outputfilteringstrategies.cpp
kdevplatform/outputview/tests/test_filteringstrategy.cpp
kdevplatform/outputview/tests/testlinebuilderfunctions.h

To: volden, #kdevelop, kfunk
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
Loading...